added is_visible returning boolean Guake show/hide status #1935
Conversation
|
For the release notes file, you'll want to actually fill it in as well. Delete the sections that aren't relevant, and fill in the sections that are. I'll test this out in the meantime |
Sure I will make the necessary changes @Davidy22 |
@Davidy22 do you want me to force push to keep the commit history clean or do you want me to create a separate commit message for these changes. |
|
Force pushing'll be better for once this gets merged |
| @@ -578,6 +585,9 @@ def main(): | |||
| remote_object.show_about() | |||
| only_show_hide = options.show | |||
|
|
|||
| if options.is_visible: | |||
| return remote_object.hidden | |||
There was a problem hiding this comment.
Looks like this needs reworking. Return values from main don't go to terminal output, this is python, the return value is just going to go to where main() was called.
There was a problem hiding this comment.
okay so rather than a return if I log this output in the shell using logging or print essentially that is what is required, am I correct?
There was a problem hiding this comment.
I assume you created this pull request to resolve #1926. That issue asks for a flag that returns the current visible state of Guake that can be used in shell scripts. This means that the method you use to return the current status must do so in a way that can be useful in a chained line of shell commands.
There was a problem hiding this comment.
This didn't meet the need of #1926:
➜ guake git:(pr_1935) ✗ python3 guake/main.py --is-visible
➜ guake git:(pr_1935) ✗ echo $?
0
If the requirement is return 1 & 0, then we should use exit for this.
Also, remote_object.hidden is a dbus.proxies._DeferredMethod, not boolean.
| @@ -578,6 +585,9 @@ def main(): | |||
| remote_object.show_about() | |||
| only_show_hide = options.show | |||
|
|
|||
| if options.is_visible: | |||
| return remote_object.hidden | |||
There was a problem hiding this comment.
This didn't meet the need of #1926:
➜ guake git:(pr_1935) ✗ python3 guake/main.py --is-visible
➜ guake git:(pr_1935) ✗ echo $?
0
If the requirement is return 1 & 0, then we should use exit for this.
Also, remote_object.hidden is a dbus.proxies._DeferredMethod, not boolean.
|
This PR has been supplanted by #2008 which works, closing. |
Added is_visible flag that returns the value of hidden variable from the guake instance which is unset and set on show and hide functions respectively.