Fix vte spawn_sync runtime check failed #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running Guake, `spawn_sync` shows runtime check failed:
```
$ guake
...
(guake:193534): VTE-WARNING **: 10:57:38.556: (../vte/src/vtepty.cc:667):bool
_vte_pty_spawn_sync(VtePty*, const char*, const char* const*,
const char* const*, GSpawnFlags, GSpawnChildSetupFunc,
gpointer, GDestroyNotify, GPid*, int,
GCancellable*, GError**):
runtime check failed: ((spawn_flags & ignored_spawn_flags()) == 0)
...
```
This is cause by setting `DO_NOT_REAP_CHILD` flag in it.
As shown in vte document & source code, `DO_NOT_REAP_CHILD` is
the default behavior for `spawn_sync`, so we don't need to pass
it when we try to `spawn_sync`.
Davidy22
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Looks good, code runs but I actually already knew that from when I was adding the SPAWN_NO_PARENT_ENVV flag, I left the flag there out of worry of breaking something that I was unaware of but I guess I didn't have to worry.
In somewhat related matters, I tried to replace spawn_sync with spawn_async but gave up partway because it broke an ungodly amount of things. spawn_sync is deprecated though, and eventually we probably want to make the move
|
Lets add migrate to |
PhungXuanAnh
pushed a commit
to PhungXuanAnh/guake
that referenced
this pull request
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Guake,
spawn_syncshows runtime check failed:This is cause by setting
DO_NOT_REAP_CHILDflag in it.As shown in vte document & source code,
DO_NOT_REAP_CHILDisthe default behavior for
spawn_sync, so we don't need to passit when we try to
spawn_sync.