Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GUAKE_ENABLE_WAYLAND environment variable #1975

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Add GUAKE_ENABLE_WAYLAND environment variable #1975

merged 2 commits into from
Nov 16, 2021

Conversation

VitalyAnkh
Copy link
Contributor

fix #1934

@mlouielu mlouielu changed the title add GUAKE_ENABLE_WAYLAND environment variable Add GUAKE_ENABLE_WAYLAND environment variable Nov 16, 2021
@mlouielu mlouielu self-requested a review November 16, 2021 06:35
@mlouielu mlouielu added this to the 3.8.2 milestone Nov 16, 2021
Copy link
Collaborator

@mlouielu mlouielu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some detail can be polished.

Also, please help update commit title with capital letter (Add ...)

guake/terminal.py Outdated Show resolved Hide resolved
guake/main.py Outdated Show resolved Hide resolved
@VitalyAnkh VitalyAnkh requested a review from mlouielu November 16, 2021 07:46
@Davidy22
Copy link
Collaborator

While we're changing this already, I kind of want to follow the recommendation from a mutter maintainer and try replacing setting GDK_BACKEND with Gdk.set_supported_backends("x11"). Does it have the same effect?

@mlouielu
Copy link
Collaborator

While we're changing this already, I kind of want to follow the recommendation from a mutter maintainer and try replacing setting GDK_BACKEND with Gdk.set_supported_backends("x11"). Does it have the same effect?

No luck on Gdk.set_allowed_backends("x11"), it doesn't work :(

Copy link
Collaborator

@mlouielu mlouielu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will need to add this to the documentation or README in separate PR.

@Davidy22
Copy link
Collaborator

Oh, documentation is pretty integral to this since there's no UI for it, but it's not that urgent because the readthedocs build is still broken and only one person has access to the account, so any docs changes we make won't be visible anyways. I'll make an issue to track it.

Also, I believe the mutter maintainer wrote Gdk.set_supported_backends("x11"), not Gdk.set_allowed_backends("x11"). Does the first one just not exist or something?

Merging because this doesn't break things for me and it apparently works for the people with wayland.

@Davidy22 Davidy22 merged commit 02ccc62 into Guake:master Nov 16, 2021
@mlouielu
Copy link
Collaborator

mlouielu commented Nov 16, 2021

Oh, documentation is pretty integral to this since there's no UI for it, but it's not that urgent because the readthedocs build is still broken and only one person has access to the account, so any docs changes we make won't be visible anyways. I'll make an issue to track it.

Also, I believe the mutter maintainer wrote Gdk.set_supported_backends("x11"), not Gdk.set_allowed_backends("x11"). Does the first one just not exist or something?

Merging because this doesn't break things for me and it apparently works for the people with wayland.

I believe its a typo for mutter maintainer, no set_support_backends in gdk3 or 4:

gtk3: https://docs.gtk.org/gdk3/index.html?q=set_supported_backends
gtk4: https://docs.gtk.org/gdk4/index.html?q=set_supported_backends

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't make Guake run under Wayland
3 participants