-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix module gi not found when make run #1989
Fix module gi not found when make run #1989
Conversation
It works, but I would like some comment from @gsemet to know the historical reason we did not put |
Well, the CI failure's probably pointing us in the direction of the reason. The first few times I threw myself at the build system are still smarting, I'll take another crack or two since someone else is going in on it too. |
I do not remember well, I think these packages did not exited at all and we requires system packages (it makes sense, gtk it tightly linked to system dependencies). |
Wait, why was this pulled? It failed CI, don't we need to fix that first? |
Sorry I though this fixed something. Should we revert? |
Hi. Think I found a fix for the CI failure. Downgrade pipenv to 2021.5.29 had solved the failure on local CI runs. Should I submit a new PR? |
Sure, please do it, and maybe we need to find out why |
Ok. |
@Davidy22 what about revert, and check the solution again? I think we should add pygobject and dbus-python into |
Since there's a PR open for fixing CI I'd probably just work in there to get it passing again. We can add things that'll make checks pass in there too. |
Please follow these steps before submitting a new Pull Request to Guake:
rebase on latest HEAD:
hack your change
to execute the code styling, checks and unit tests:
$ make style check reno-lint test
describe your change in a slug file for automatic release note
generation, using:
and edit the created file in
releasenotes/notes/
.You can see how
reno
works usingpipenv run reno --help
.Please use a generic slug (eg, for translation update,
use
translation
, for bugfix usebugfix
,...)create new commit message
If your change is related to a GitHub issue, you can add a reference
using
#123
where 123 is the ID of the issue.You can use
closes #123
to have GitHub automatically close the issuewhen your contribution get merged
Semantic commit is supported (and recommended). Add one of the following
line in your commit messages: