Revert "ci: no pipeline on pull_request" #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 517745d.
|
Hold on, why did it run here, but not in the other PR? Well since this apparently wasn't stopped, closing. |
|
Actually, maybe CI ran because this pull request is restoring CI? The next time another pull request comes in we can see if CI isn't run again on it. |
|
Agree, apparently it does not work exactly like in gitlab. My mistake |
gsemet
approved these changes
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 517745d.
Despite assurance that removing pull_request wouldn't wipe CI runs from pull requests, we can see in #2017 that removing pull_request wipes CI runs from pull requests.