Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TERM_PROGRAM environment variable like other well-known terminals #2063

Merged
merged 1 commit into from
Apr 3, 2022

Conversation

kohnish
Copy link
Contributor

@kohnish kohnish commented Mar 31, 2022

for shell run commands

Copy link
Collaborator

@Davidy22 Davidy22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can ignore the deepsource complaint, change looks fine, just need a release note file filled in, just do a make reno SLUG=[descriptive_label] and fill in the release note file like how it is in other PRs.

Copy link
Collaborator

@Davidy22 Davidy22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to need to deal with the thing deepsource is complaining about in a bit, think it should be straightforward but that's another issue, I'll merge this.

@Davidy22 Davidy22 merged commit ea2aeb4 into Guake:master Apr 3, 2022
@kohnish kohnish deleted the envvar branch April 4, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants