Add Neeva.com search engine #2133
Conversation
There was a problem hiding this comment.
I do want to eventually shift towards the thing I mentioned in the original pull request where we have a way to enter your own search engine in preferences because I really don't want the endgame for this to be a mile long list of search engines, but I won't say no to additions. This PR does need a little revision though, because as it is currently, the search engine won't actually show up in the list of options in preferences. Need to mirror the changes in the prefs.glade file, put your addition in the same relative spot in the drop down list so that people can actually choose it. You should be able to install and test your changes to see if they work as intended with a sudo make install
A release notes file generated with make reno SLUG=neeva_search_engine or some other descriptive header filled in would also be nice to smooth the wheels on pulling this.
|
I can work on allowing users to add whatever search engine |
|
Oh certainly that would be very welcome |
|
Closing because superceded by #2134 |
|
W00t! Yeah, much better to go with user entered, custom search engines! Thank you! |
Follow up to #2088 by @PhantomLel.