Extra color schemes #504
Extra color schemes #504
Conversation
…or the rest of the palettes
|
please rebase. Look quite good |
| @@ -388,12 +995,6 @@ def on_use_default_font_toggled(self, chk): | |||
| """ | |||
| self.client.set_bool(KEY('/general/use_default_font'), chk.get_active()) | |||
|
|
|||
| def on_use_palette_font_and_background_color_toggled(self, chk): | |||
|
Thanks, I was at work so I couldn't reply. I will take a look at them tomorrow and let you know. |
Fullscreen fixes.
Signed-off-by: Gaetan Semet <gaetan@xeberon.net>
Signed-off-by: Gaetan Semet <gaetan@xeberon.net>
Signed-off-by: Gaetan Semet <gaetan@xeberon.net>
Signed-off-by: Gaetan Semet <gaetan@xeberon.net>
…or the rest of the palettes
… extra-color-schemes * 'extra-color-schemes' of github.com:varemenos/guake: fixed typo added Adonis K. to the contributors refactored color palettes, loaded everything from https://github.com/varemenos/guake-color-palettes correct foreground and background colors for solarized dark fixed solarized dark palette, added foreground and background color for the rest of the palettes positioned the background before foreground color of palettes added front and background colors to monokai, lucario, cobalt2 and flatland palettes
|
Ok, so I tried rebasing the branch, could you please review it again? |
| @@ -848,14 +1420,6 @@ def load_configs(self): | |||
| self.set_palette_name(value) | |||
| self.set_palette_colors(value) | |||
|
|
|||
| # cursor shape | |||
There was a problem hiding this comment.
please review your rebase, you are removing my recent changes
use git pull --rebase
|
I cherry pick your patch and make the necessary correction and merge |
|
I have merge your patch, fixes the bad rebase, and pushed. So I close your Pull Request. So thanks a lot for your effort. Can you check if I have not forgot something from your PL? However, is it normal to have so many theme with bright background color? (I mean, because i feel more confortable with dark background). Next step is for me, provide a convinient previsualisation for the user |
|
Ok, thanks for taking the time to fix my broken PR. Sorry for not doing it myself but I was too busy at work. I will try find some free time and research a good way to present the color schemes to the user |
|
I Will Work on it. Can you check the color coherence? |
|
Yes, I will do it tonight |
|
Please look how I reorganised palette definition, this should be quite easier to add or modify palettes :) |
|
Will do. I will also update the palette string generator I'm using. |
|
Yes, it is a dictionary now, with names and colors in the same file ! :) |
|
Thanks again for your work |
|
I just checked the colors of the |
Could you please review the changes (apart from the changes related to the color schemes), I'm not sure whether they are valid or not