use dconf for ubuntu launcher hide/width detection #509
Conversation
| if float(platform.dist()[1])>=12.10: | ||
| unity_hide = int(subprocess.check_output( | ||
| ['/usr/bin/dconf', 'read', | ||
| '/org/compiz/profiles/unity/plugins/unityshell/launcher-hide-mode'])) |
There was a problem hiding this comment.
Oh please no, we do not want to shell out command.
There was a problem hiding this comment.
OK, what is the python way to do it then. I'm a python amateur.
There was a problem hiding this comment.
I'm fairly sure dconf has a python API.
There was a problem hiding this comment.
OK. Then I hope that this issue is fixed the correct way soon.
There was a problem hiding this comment.
i'll check that but I remember that there was some dependencies problem... so I ended up executing this command for other use case :(
There was a problem hiding this comment.
arf :( we would really prefer to avoid this.
There was a problem hiding this comment.
that's a chicken and egg problem. This should be handled by the packager (for debian, for rehat, ...). But, as a User, I want to be able to use Guake directly from source. And as a Maintainer, I don't want packager to introduce regression in my software.... So I don't see how to handle distribution specific stuff differently.
Maybe a good thing to do is to move this trick in a spefic module so distribution hack are better identified
|
I merge and give a try on my system. I'll switch to ubuntu 15.04 today |
use dconf for ubuntu launcher hide/width detection
use dconf for ubuntu launcher hide/width detection
use dconf for ubuntu launcher hide/width detection
The affected code is tested on my Ubunut 15.04 and documented.
current guake's detection about ubuntu launcher's hide state and icon size is not working.
Now dconf is used to solve this problem. (for ubuntu >=12.10)
I believe the change is quite straightforward.