Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break shadowtext.
This PR copies the contents of the removed
add_margins()
function. Briefly, the use of unexported functions is discouraged, as ggplot2 makes no that they continue to exist. For more information about this issue, please see https://www.tidyverse.org/blog/2022/09/playing-on-the-same-team-as-your-dependecy/. Whileadd_margins()
is the one that broke shadowtext this time, there are others that are equally brittle found here:shadowtext/R/element_shadowtext.R
Lines 106 to 111 in b810ebc
To test the code changes with the release candidate, you can install it with the code below:
The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help shadowtext get out a fix if necessary.