Co-authored-by: Maarten Steevens <maarten.steevens@gmail.com>
Co-authored-by: Timothy Geerkens <timothy.geerkens@guardsquare.com>

We ran the inliner on a real world application and found a lot of issues, this commit aims to resolve those.

… klox-fixes

Made LambdaUsageHandler a class
Put loadJar inside testUtil.kt and removed LambdaLocator.Util
Added comments in CastRemover

We can do some of these changes because we don't modify the code in this version

…odHandler class

…anymore

… klox-fixes

Refactored LambdaImplementationVisitor visitProgramMethod

Cleaned commented code in NullCheckRemover
Removed unused class
Removed staircase in LocalUsageRemover

…terativeInstructionVisitor class

… klox-fixes

Fixes from inlining lambdas in the klox compiler

added a logger in lambda locator

…he arguments

… descriptor

This is better because it fixes the case where a lambda is attempted to be inlined into a method that takes object as argument which is then later casted back into a lambda.

…sage finder

… recursive-inliner-adjustments

Recursive inliner adjustments + comments

… more-fixes

Fixed the cast remover so it works in all cases

…ngth when decided to not inline the lambda

…hod is not inlined when it is too long

Conditionally inline lambdas

Co-authored-by: rubenpieters <rubenpieters@users.noreply.github.com>

Co-authored-by: rubenpieters <rubenpieters@users.noreply.github.com>

… lambda-inlining

… and then reading it again from the iterativeInstructionVisitor

Resolved infinite loop when tracing source instruction of unreachable code

… lambda-inlining

Co-authored-by: rubenpieters <rubenpieters@users.noreply.github.com>

…at some methods don't have a length

… lambda-inlining

…cator

…javadoc to Lambda class to explain what each argument/field represents

+ added debug messages

… lambda-inlining

…ally changed

…he BaseLambdaInliner.inline() method

…ass because the visitors are not part of the API of the BaseLambdaInliner

…mbda inlining without recompiling

…e so it matches the package name used in the tests and it also is just more informative, the MethodInliner for example was not in there

…tlin

(Location can maybe be changed not sure exactly where we should put it, putting it in the official documentation seems incorrect this is not really something a proguard user should know it's more of a developer oriented piece of documentation.)

…ferences have to be updated, just the classes involved in the inlining process

This should improve performance a bit.

This should also improve performance a bit.

…lassPool

This should again improve performance of the pass a bit.

… method and lambda length