Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minJosmVersion for JOSM r17867 #25

Merged
merged 2 commits into from
May 19, 2021
Merged

Bump minJosmVersion for JOSM r17867 #25

merged 2 commits into from
May 19, 2021

Conversation

tsmock
Copy link
Contributor

@tsmock tsmock commented May 17, 2021

This fixes JOSM #20882

Note: It looks like the build is failing since I haven't set a GITHUB_ACCESS_TOKEN variable.

Signed-off-by: Taylor Smock <tsmock@fb.com>
@tsmock tsmock marked this pull request as draft May 17, 2021 17:58
@tsmock

This comment has been minimized.

Signed-off-by: Taylor Smock <tsmock@fb.com>
@tsmock tsmock marked this pull request as ready for review May 18, 2021 13:44
@Gubaer
Copy link
Owner

Gubaer commented May 18, 2021

Thanks @tsmock! Sorry for the delay. I'm working on it.

@tsmock
Copy link
Contributor Author

tsmock commented May 18, 2021

No problem -- you really couldn't have merged it yesterday, as I needed to update the compile version to something that could be downloaded. And I consider < 1 week response times to be good for OSS anyway. :)

@Gubaer Gubaer merged commit 5f907cd into Gubaer:master May 19, 2021
@Gubaer
Copy link
Owner

Gubaer commented May 19, 2021

Merged and published in v1.0.7

Thanks a lot!

@tsmock tsmock deleted the josm-17177 branch May 19, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants