-
Notifications
You must be signed in to change notification settings - Fork 2
Dev #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Dev #1
Conversation
rae-ralston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it's looking good. It's a little harder to do an in depth review because much of this was scaffolded by someone else. But the changes you've made here make sense, the naming conventions are much more self evident.
src/routes/review.js
Outdated
| userFunctions.getById(cityReviews.user_id) | ||
| .then((reviewer) => { | ||
| response.render('reviews/viewFull', { reviews: cityReviews, user: reviewer, city: true }); | ||
| response.render('reviews/FullUserReview', { reviews: cityReviews, user: reviewer, city: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a lower case F or uppercase on FullUserReview?
…ic or definitions
…ic or definitions
…ic or definitions
Monday's Completed Tasks