Skip to content

Conversation

@latoyazamill
Copy link

Monday's Completed Tasks

  • Move the public directory to the root of the project
  • Update the database folder to be organized according to the MVC pattern
  • Update file names to indicate the RESOURCE being worked on -- Eg: path of the users file should be ./src/models/db/users.js
  • Update files inside the views folder to be organized according to the RESOURCE
  • Update folder names to represent the RESOURCE.
  • Update file names to represent the VERB/ACTION

Copy link

@rae-ralston rae-ralston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's looking good. It's a little harder to do an in depth review because much of this was scaffolded by someone else. But the changes you've made here make sense, the naming conventions are much more self evident.

userFunctions.getById(cityReviews.user_id)
.then((reviewer) => {
response.render('reviews/viewFull', { reviews: cityReviews, user: reviewer, city: true });
response.render('reviews/FullUserReview', { reviews: cityReviews, user: reviewer, city: true });

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a lower case F or uppercase on FullUserReview?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants