Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump csharpier from 0.28.2 to 0.29.1 #30

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 26, 2024

Bumps csharpier from 0.28.2 to 0.29.1.

Release notes

Sourced from csharpier's releases.

0.29.1

What's Changed

Sorting of usings with underscore differs from Visual Studio #1327

CSharpier now sorts _ to the bottom of usings.

using SomeCompany.MWord;
using SomeCompany.ZWord;
using SomeCompany._Word;

Process cannot access the file "....net8.0\any\server.log" while running multiple extensions. #1324

CSharpier Server now uses a log file name based on the port that it is starting on to avoid concurrency issues trying to access the same log file

Full Changelog: belav/csharpier@0.29.0...0.29.1

0.29.0

Breaking Changes

The formatting command will now exit with an error code of 1 if one of the target files cannot be compiled #1131

Prior to 0.29.0 if csharpier encountered a file that could not be compiled it would treat it as a warning and exit with a code of 0.
As of 0.29.0 a file that cannot be compiled is now treated as an error and csharpier will exit with code 1

What's Changed

Enforce trailing commas in object and collection initializer #668

CSharpier will now add trailing commas automatically where appropriate. It will collapse to a single line and remove the trailing comma in cases where everything fits on one line.

// input
public enum SomeEnum
{
    Value1,
    Value2
}
string[] someArray = new string[]
{
someLongValue_____________________________________________,
someLongValue_____________________________________________
};
string[] someArray = new string[]
{
someValue,
someValue,
};
// 0.29.0
public enum SomeEnum
{
Value1,
Value2,
}
</tr></table>

... (truncated)

Changelog

Sourced from csharpier's changelog.

# 0.29.1

What's Changed

Sorting of usings with underscore differs from Visual Studio #1327

CSharpier now sorts _ to the bottom of usings.

using SomeCompany.MWord;
using SomeCompany.ZWord;
using SomeCompany._Word;

Process cannot access the file "....net8.0\any\server.log" while running multiple extensions. #1324

CSharpier Server now uses a log file name based on the port that it is starting on to avoid concurrency issues trying to access the same log file

Full Changelog: belav/csharpier@0.29.0...0.29.1

0.29.0

Breaking Changes

The formatting command will now exit with an error code of 1 if one of the target files cannot be compiled #1131

Prior to 0.29.0 if csharpier encountered a file that could not be compiled it would treat it as a warning and exit with a code of 0.
As of 0.29.0 a file that cannot be compiled is now treated as an error and csharpier will exit with code 1

What's Changed

Enforce trailing commas in object and collection initializer #668

CSharpier will now add trailing commas automatically where appropriate. It will collapse to a single line and remove the trailing comma in cases where everything fits on one line.

// input
public enum SomeEnum
{
    Value1,
    Value2
}
string[] someArray = new string[]
{
someLongValue_____________________________________________,
someLongValue_____________________________________________
};
string[] someArray = new string[]
{
someValue,
someValue,
};
// 0.29.0
public enum SomeEnum
{
Value1,
Value2,
}
string[] someArray = new string[]
</tr></table>

... (truncated)

Commits
  • b87b4df Releasing 0.29.1 (#1331)
  • 10e0780 Support for multiple csharpier servers running at the same time, have them wr...
  • 2ed8622 Getting _ to sort to the top like it should (#1328)
  • 688aeb7 VS - Use dotnet tool list to find both local and global installs of csharpier...
  • 1cdcf0a fix width
  • c529570 prettier all the java
  • 88383e7 Using dotnet tool list for rider extension (#1325)
  • 2456512 Modify VSCode extension to use dotnet tool list + only warn to instal… (#1323)
  • 6cb3821 Format with 29 (#1322)
  • 0abbc1d fix typo
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Description by Korbit AI

What change is being made?

Bump csharpier from version 0.28.2 to 0.29.1 in the .config/dotnet-tools.json file.

Why are these changes being made?

This update includes bug fixes and performance improvements provided in the newer version of csharpier. Keeping dependencies up-to-date ensures the project benefits from the latest enhancements and maintains compatibility with other tools.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 26, 2024

The following labels could not be found: nuget, .NET, packages, dependencies.

Copy link

Hi there! 👋 Thanks for opening a PR. It looks like you've already reached the 5 review limit on our Basic Plan for the week. If you still want a review, feel free to upgrade your subscription in the Web App and then reopen the PR

Copy link

semanticdiff-com bot commented Aug 26, 2024

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Overall, the semantic diff is 99% smaller than the GitHub diff.

Filename Status
✔️ .config/dotnet-tools.json 98.89% smaller

Copy link

gooroo-dev bot commented Aug 26, 2024

Please double check the following review of the pull request:

Issues counts

🐞Mistake 🤪Typo 🚨Security 🚀Performance 💪Best Practices 📖Readability ❓Others
0 0 0 0 0 1 1

Changes in the diff

  • 🛠️ Bumped the version of csharpier from 0.28.2 to 0.29.1.
  • 📖 Improved indentation for better readability.
  • ❓ Added a newline at the end of the file.

Identified Issues

ID Type Details Severity Confidence
1 📖Readability Inconsistent indentation in the JSON file. 🟡Low 🟡Low
2 ❓Others Missing newline at the end of the file. 🟡Low 🟡Low

Issue 1: Inconsistent indentation in the JSON file

  • Details: The indentation in the JSON file was inconsistent, which could affect readability and maintainability.
  • File Path: .config/dotnet-tools.json
  • Lines: 2-12

Proposed Fix:

{
  "version": 1,
  "isRoot": true,
  "tools": {
    "csharpier": {
      "version": "0.29.1",
      "commands": [
        "dotnet-csharpier"
      ]
    }
  }
}

Explanation: The indentation has been corrected to ensure consistent formatting throughout the JSON file.

Issue 2: Missing newline at the end of the file

  • Details: The JSON file is missing a newline at the end, which is a common best practice for text files.
  • File Path: .config/dotnet-tools.json
  • Lines: 14

Proposed Fix:

{
  "version": 1,
  "isRoot": true,
  "tools": {
    "csharpier": {
      "version": "0.29.1",
      "commands": [
        "dotnet-csharpier"
      ]
    }
  }
}

Explanation: Added a newline at the end of the file to adhere to best practices.

Missing Tests

Since the changes are related to configuration and version bump, no additional tests are required. The functionality of the tool csharpier should be verified through its own test suite.

Summon me to re-review when updated! Yours, Gooroo.dev
Your input is valuable! Please reply or add a reaction.

Copy link

korbit-ai bot commented Aug 26, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

Copy link

pr-code-reviewer bot commented Aug 26, 2024

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

Copy link

Potential issues, bugs, and flaws that can introduce unwanted behavior:

  1. /.config/dotnet-tools.json
    • The version of the csharpier tool has been updated from "0.28.2" to "0.29.1", but the isRoot property is inconsistently aligned. This could lead to confusion and maintenance issues in the future.

Code suggestions and improvements for better exception handling, logic, standardization, and consistency:

  1. /.config/dotnet-tools.json
    • Ensure consistent indentation within the JSON file by aligning the isRoot property correctly under the csharpier tool definition, maintaining a clean and organized structure.

Copy link

coderabbitai bot commented Aug 26, 2024

Warning

Rate limit exceeded

@gstraccini[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 25 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between eaa5fc5 and 90a933d.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

instapr bot commented Aug 26, 2024

Feedback on PR

  • The csharpier package has been successfully updated from 0.28.2 to `0.29.1.
  • The .config/dotnet-tools.json file was updated accordingly.
  • No newline at the end of the file.

Overall, the PR looks good. Thank you for the contribution! 🚀

Copy link

deepsource-io bot commented Aug 26, 2024

Here's the code health analysis summary for commits eaa5fc5..90a933d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource C# LogoC#✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateC#
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 26, 2024
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code and did not find any issues!


Please note that I can make mistakes, and you should still encourage your team to review your code as well.

@guibranco guibranco enabled auto-merge (squash) August 26, 2024 13:51
@gstraccini gstraccini bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Aug 26, 2024
Bumps [csharpier](https://github.com/belav/csharpier) from 0.28.2 to 0.29.1.
- [Release notes](https://github.com/belav/csharpier/releases)
- [Changelog](https://github.com/belav/csharpier/blob/main/CHANGELOG.md)
- [Commits](belav/csharpier@0.28.2...0.29.1)

---
updated-dependencies:
- dependency-name: csharpier
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/csharpier-0.29.1 branch from 0eb3434 to 90a933d Compare August 26, 2024 13:51
Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Automated processes or integrations label Aug 26, 2024
@guibranco
Copy link
Member

@dependabot squash and merge

Copy link

sonarcloud bot commented Aug 26, 2024

Copy link

Infisical secrets check: ✅ No secrets leaked!

Scan results:

1:52PM INF scanning for exposed secrets...
1:52PM INF 23 commits scanned.
1:52PM INF scan completed in 65.1ms
1:52PM INF no leaks found

@guibranco guibranco merged commit 991a653 into main Aug 26, 2024
14 checks passed
@guibranco guibranco deleted the dependabot/nuget/csharpier-0.29.1 branch August 26, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) 🤖 bot Automated processes or integrations korbit-code-analysis size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant