-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DiskRefreshKind
#1387
Add DiskRefreshKind
#1387
Conversation
d47e355
to
4068e14
Compare
I think it's great as a first step, thanks! For the |
For my specific use case, I need to be able to opt out of Having the Can you elaborate on what your concern is? |
Just personal taste but it's not really a valid argument. 😅 Then let's do it. So: please add the possibility to opt out of the Finally, please add a test checking that each state of the |
I'm okay with this, but I think it contradicts the existing sysinfo docs, which say:
... so just want to confirm: you want to test that we respect
On it. |
f0b6c7f
to
9624d5a
Compare
Yep. We should also remove this sentence. |
And once done with linux, will remain apple, windows and freebsd. If needed, I can update the ones you can't. |
621e11b
to
89404de
Compare
@GuillaumeGomez I've done the linux, apple and freebsd implementations, but I don't have easy access to a windows system. The osx tests are now failing on a seemingly-unrelated libc problem that I don't think I could have caused (unless it's somehow by touching Cargo.toml?) Any ideas on those? |
For the libc issue, it was fixed in #1393. So just a rebase will fix the CI. Gonna review the code to see if anything else is missing. Very excited about this change! |
It's fine. Time for a final review then. Finishing something else then review time! |
Ok I think it's all I found. |
c98dedc
to
78f0362
Compare
Thanks! |
fixes #1375.
DiskRefreshKind
, following the existing pattern (except thatkind
defaults to true)_specifics
variants ofDisk
andDisks
constructors and refresh methodsDisk
andDisks
to allow precise control over what gets loadedQuestions / unresolved bits:
DiskKind
when the user explicitly refreshes.without_kind()