Add SystemExt::distribution_id() #844
Conversation
legeana
changed the title
|
I am working on test failures. |
src/traits.rs
Outdated
| /// Returns the distribution id as defined by os-release, | ||
| /// or OS-name if unavailable. |
There was a problem hiding this comment.
What do you think about:
| /// Returns the distribution id as defined by os-release, | |
| /// or OS-name if unavailable. | |
| /// Returns the distribution id as defined by os-release, | |
| /// or [`std::env::consts::OS`]. |
?
|
A few small nits but otherwise looks great! |
legeana
force-pushed
the
distribution_id
branch
3 times, most recently
from
41739a4 to
ec1d180
Compare
legeana
changed the title
src/lib.rs
Outdated
| @@ -344,6 +344,8 @@ mod test { | |||
| .long_os_version() | |||
| .expect("Failed to get long OS version") | |||
| .is_empty()); | |||
|
|
|||
| assert!(!s.distribution_id().is_empty()); | |||
There was a problem hiding this comment.
Please move this test outside of the if System::IS_SUPPORTED since it can definitely work even on unknown targets.
There was a problem hiding this comment.
Done. Please take a look if this is what you meant.
|
For the once_cell failures, don't worry. I think I'll send a PR to update the minimum supported rust version or enforce the usage of a previous one to prevent breaking the CI. Not sure which way is better... |
legeana
force-pushed
the
distribution_id
branch
2 times, most recently
from
20d32d6 to
3fe5715
Compare
Thank you for clarification! |
SystemExt::name() returns human-readable distribution name, but there is no machine-readable alternative. SystemExt::distribution_id() returns os-release.ID, or std::env::consts::OS if os-release.ID is unavailable. Fallback behaviour is consistent with the os-release.ID specification on Linux. See also - https://www.freedesktop.org/software/systemd/man/os-release.html#ID= - https://doc.rust-lang.org/std/env/consts/constant.OS.html Closes GuillaumeGomez#843.
legeana
force-pushed
the
distribution_id
branch
from
3fe5715 to
ceef6b0
Compare
|
Thanks for adding this feature! I'll make a release not too far in the future. |
SystemExt::name() returns human-readable distribution name, but there is no machine-readable alternative.
SystemExt::distribution_id() returns os-release.ID, or std::env::consts::OS if os-release.ID is unavailable. Fallback behaviour is consistent with the os-release.ID specification on Linux.
See also
Closes #843.