Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Unsupported EncryptionType Gracefully #15

Closed
GurpreetKang opened this issue Jul 6, 2022 · 2 comments
Closed

Handle Unsupported EncryptionType Gracefully #15

GurpreetKang opened this issue Jul 6, 2022 · 2 comments
Assignees
@GurpreetKang
Labels
bug Something isn't working

Comments

@GurpreetKang
Copy link
Owner

Decryption of the Protected Symmetric Key assumes the EncryptionType = 2 (AesCbc256_HmacSha256_B64) and will fail if it is anything else.
Old Bitwarden accounts may be using EncryptionType = 0 (AesCbc256_B64)

This should be handled gracefully with a meaningful error message.
GurpreetKang added a commit that referenced this issue Jul 6, 2022
@GurpreetKang
Handle Unsupported EncryptionType Gracefully
090bf06 
More descriptive error message.

#15
@GurpreetKang GurpreetKang added the bug Something isn't working label Jul 6, 2022
@GurpreetKang GurpreetKang self-assigned this Jul 6, 2022
@GurpreetKang GurpreetKang reopened this Jul 6, 2022
@GurpreetKang
Copy link
Owner Author

Previous commnit was incomplete fix.

@GurpreetKang
Copy link
Owner Author

d801cb2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GurpreetKang GurpreetKang

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GurpreetKang