Handle HTTP and network errors according to gRPC spec on client #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noaelad
changed the title
noaelad
changed the title
kryptonat
approved these changes
Jun 30, 2020
| AllCops: | ||
| Exclude: | ||
| - 'spec/pb-ruby/goodbye_pb.rb' | ||
| - vendor/bundle/**/* |
There was a problem hiding this comment.
Why is Rubocop looking in vendor/bundle?
There was a problem hiding this comment.
I dunno, but it is without this excludes statement. I think it's just looking in all the subfolders.
It actually manifests in rubocop complaining about the ruby version of some dependency oddly enough
https://app.circleci.com/pipelines/github/Gusto/grpc-web-ruby/174/workflows/e6045431-6d32-47a7-84ca-68a6318aa268/jobs/330/steps
A similar excludes statement exists in ZP.
jeantessier
approved these changes
Jul 1, 2020
noaelad
changed the title
noaelad
changed the title
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the spec defined here:
https://github.com/grpc/grpc/blob/master/doc/http-grpc-status-mapping.md