Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle HTTP and network errors according to gRPC spec on client #28

Merged
merged 3 commits into from
Jul 8, 2020
+8 −1
Merged

feat: Handle HTTP and network errors according to gRPC spec on client #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78edf0b
FIX: Add documentation about commit message format
noaelad Jul 7, 2020
993b80b
add another chrome dependency
noaelad Jul 7, 2020
6ac724d
Update CONTRIBUTING.md
noaelad Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,10 @@ Use the `rake` command to run the entire test suite. This runs on docker due to

### Unit tests

Unit tests can be run without docker by running `rspec spec/unit`
Unit tests can be run without docker by running `rspec spec/unit`

### Commit message format

Please follow semantic release formatting
https://semantic-release.gitbook.io/semantic-release/#commit-message-format
https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#type
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ RUN apt-get update && apt-get install -y \
libatspi2.0-0 \
libcups2 \
libdbus-1-3 \
libgbm1 \
libgtk-3-0 \
libnspr4 \
libnss3 \
Expand Down