Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto: how path to static files (images and locales) are resolved in Python and frozen mode (pyinstaller) #225

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Mar 15, 2024

This pr fixes this error:

Uploading Capture d'écran 2024-03-15 110758.png…

@github-actions github-actions bot added bug Houston, we've a problem! CLI Command Line Interface quality labels Mar 15, 2024
@Guts Guts added GUI Related to graphical user interface packaging and removed quality labels Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 45.16129% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 20.71%. Comparing base (0d2930b) to head (07668e5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   20.41%   20.71%   +0.29%     
==========================================
  Files          37       37              
  Lines        3017     3032      +15     
  Branches      308      310       +2     
==========================================
+ Hits          616      628      +12     
- Misses       2371     2372       +1     
- Partials       30       32       +2     
Flag Coverage Δ
unittests 20.71% <45.16%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dicogis/__about__.py 100.00% <100.00%> (ø)
dicogis/constants.py 93.54% <ø> (ø)
dicogis/cli/cmd_list.py 0.00% <0.00%> (ø)
dicogis/georeaders/process_files.py 0.00% <0.00%> (ø)
dicogis/utils/notifier.py 0.00% <0.00%> (ø)
dicogis/utils/texts.py 80.00% <71.42%> (-3.34%) ⬇️
dicogis/utils/utils.py 40.00% <66.66%> (+6.15%) ⬆️
dicogis/DicoGIS.py 0.00% <0.00%> (ø)

@Guts Guts merged commit 32fbdc2 into master Mar 15, 2024
7 checks passed
@Guts Guts deleted the fix/static-resources-path-resolving branch March 15, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Houston, we've a problem! CLI Command Line Interface GUI Related to graphical user interface packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant