Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto(serializer): change code structure to handle new serializers #276

Merged
merged 3 commits into from
May 24, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented May 24, 2024

No description provided.

@github-actions github-actions bot added the CLI Command Line Interface label May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 9.67742% with 112 lines in your changes are missing coverage. Please review.

Project coverage is 26.34%. Comparing base (20c256d) to head (2d93ef3).

Current head 2d93ef3 differs from pull request most recent head 6868754

Please upload reports for the commit 6868754 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   26.53%   26.34%   -0.20%     
==========================================
  Files          37       39       +2     
  Lines        2536     2581      +45     
  Branches      322      324       +2     
==========================================
+ Hits          673      680       +7     
- Misses       1818     1856      +38     
  Partials       45       45              
Flag Coverage Δ
unittests 26.34% <9.67%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dicogis/constants.py 96.96% <100.00%> (+0.09%) ⬆️
dicogis/utils/utils.py 36.61% <100.00%> (ø)
dicogis/export/base_serializer.py 62.50% <62.50%> (ø)
dicogis/cli/cmd_inventory.py 0.00% <0.00%> (ø)
dicogis/ui/main_windows.py 0.00% <0.00%> (ø)
dicogis/export/to_json.py 0.00% <0.00%> (ø)
dicogis/export/to_xlsx.py 12.01% <25.00%> (+0.32%) ⬆️
dicogis/georeaders/process_files.py 0.00% <0.00%> (ø)

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts enabled auto-merge May 24, 2024 15:17
@Guts Guts merged commit 0996745 into master May 24, 2024
7 checks passed
@Guts Guts deleted the refacto/serializing-process branch May 24, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Command Line Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant