Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serializer): circular import in class method #302

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Jun 6, 2024

No description provided.

@github-actions github-actions bot added the bug Houston, we've a problem! label Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 23.90%. Comparing base (9191965) to head (e6b0c77).

Current head e6b0c77 differs from pull request most recent head 2014fe6

Please upload reports for the commit 2014fe6 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   23.91%   23.90%   -0.01%     
==========================================
  Files          41       41              
  Lines        2772     2773       +1     
  Branches      381      381              
==========================================
  Hits          663      663              
- Misses       2062     2063       +1     
  Partials       47       47              
Flag Coverage Δ
unittests 23.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dicogis/export/base_serializer.py 0.00% <0.00%> (ø)

@Guts Guts enabled auto-merge June 6, 2024 11:50
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts merged commit 4d7623f into master Jun 6, 2024
8 checks passed
@Guts Guts deleted the fix/circular-import-in-base-serializer branch June 6, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Houston, we've a problem!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant