Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add http caching mechanism #309

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Feature: add http caching mechanism #309

merged 5 commits into from
Jun 25, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Jun 25, 2024

This PR aims to improve plugin's performance regarding HTTP requests which are performed to retrieve remote image length:

For now, it works only for GET requests. See upstream issue: psf/cachecontrol#337

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file quality Tests, project resiliency, etc. labels Jun 25, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jun 25, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 25, 2024
Copy link

sonarcloud bot commented Jun 25, 2024

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (96c0404) to head (96fec9f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
+ Coverage   80.75%   80.99%   +0.23%     
==========================================
  Files          10       10              
  Lines         634      642       +8     
  Branches      131      131              
==========================================
+ Hits          512      520       +8     
  Misses         84       84              
  Partials       38       38              
Flag Coverage Δ
unittests 80.84% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mkdocs_rss_plugin/config.py 100.00% <100.00%> (ø)
mkdocs_rss_plugin/constants.py 100.00% <100.00%> (ø)
mkdocs_rss_plugin/plugin.py 90.22% <100.00%> (+0.14%) ⬆️
mkdocs_rss_plugin/util.py 74.33% <100.00%> (+0.29%) ⬆️

@Guts Guts merged commit 97ce5dd into main Jun 25, 2024
11 checks passed
@Guts Guts deleted the feature/add-http-cache branch June 25, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant