Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: QDT0.28 does not recognise a Git repository as a Git repository #344

Closed
1 task done
NROLLANDGrandlyon opened this issue Nov 15, 2023 · 1 comment · Fixed by #346
Closed
1 task done

[BUG]: QDT0.28 does not recognise a Git repository as a Git repository #344

NROLLANDGrandlyon opened this issue Nov 15, 2023 · 1 comment · Fixed by #346
Assignees
Labels
bug Something isn't working

Comments

@NROLLANDGrandlyon
Copy link

Is there an existing issue or a documentation page for this?

  • I have searched the existing issues and within documentation

Which version of the app are you using?

Windows_QGISDeploymentToolbelt_0-28-0.exe

Operating System

Windows 10+*

Packaging mode

Stand-alone executable (.i.e qdt.exe)

Related resources

No response

Description of the bug

In the scenario repository is defined as
protocol: git
source: file://\svcficapp01-dev.grandlyon.fr\APPLISIT\APPLI\LSM\QGIS\DEV\qgis3

This directory is a Git repo synchronised with Git Desktop.
It works fine with version 0.26 but not with version 0.28 with the error message:

Traceback (most recent call last):
File "qgis_deployment_toolbelt\commands\deployment.py", line 201, in run
File "qgis_deployment_toolbelt\jobs\job_profiles_synchronizer.py", line 121, in run
File "qgis_deployment_toolbelt\profiles\local_git_handler.py", line 68, in init
dulwich.errors.NotGitRepository: \svcficapp01-dev.grandlyon.fr\APPLISIT\APPLI\LSM\QGIS\DEV\qgis3 is not a valid Git repository.

Same error with another repo

Steps to reproduce

run Windows QDT 0.28.exe with a Git repo in qprofiles-manager

Relevant log output

No response

Comment

No response

@NROLLANDGrandlyon NROLLANDGrandlyon added the triage To be qualified, waiting for a project manager label Nov 15, 2023
@Guts Guts added bug Something isn't working and removed triage To be qualified, waiting for a project manager labels Nov 15, 2023
@Guts Guts closed this as completed in #346 Nov 16, 2023
Guts added a commit that referenced this issue Nov 16, 2023
- git handlers are more generic
- local and remote git handlers are tested specifically 

closes #344
@Guts
Copy link
Owner

Guts commented Nov 16, 2023

Thanks for taking time to report here. Indeed, the local git repositories were not recognized anymore.

Fix shipped in version 0.29.0: https://github.com/Guts/qgis-deployment-cli/releases/tag/0.29.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants