Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: handle "local" plugins #253

Merged
merged 11 commits into from
Apr 14, 2023
Merged

Feature: handle "local" plugins #253

merged 11 commits into from
Apr 14, 2023

Conversation

Guts
Copy link
Owner

@Guts Guts commented Apr 13, 2023

Until now, only "remote" plugins were managed. This PR adds ability to copy plugins stored locally.

Typically in a profile.json:

{
  "$schema": "https://raw.githubusercontent.com/Guts/qgis-deployment-cli/main/docs/schemas/profile/qgis_profile.json",
  "name": "basic",
  "author": "QDT Dev Team",
  "email": "qgis@oslandia.com",
  "icon": "images/qgis.ico",
  "splash": "images/splash.png",
  "qgisMinimumVersion": "3.16",
  "qgisMaximumVersion": "3.30",
  "version": "1.0.0",
  "plugins": [
    {
      "name": "Spreadsheet Layers",
      "folder_name": "SpreadsheetLayers",
      "official_repository": true,
      "plugin_id": 766,
      "version": "2.0.0"
    },
    {
      "name": "Custom intra plugin",
      "folder_name": "intra_plugin",
      "official_repository": false,
      "plugin_id": 202303,
      "location": "local",
      "url": "S://QGIS//plugins//intra-plugin.zip"
    }
}

@Guts Guts self-assigned this Apr 13, 2023
@github-actions github-actions bot added the jobs Scenarios and jobs label Apr 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #253 (1e64a61) into main (a0b14b8) will decrease coverage by 3.13%.
The diff coverage is 28.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   67.93%   64.81%   -3.13%     
==========================================
  Files          34       35       +1     
  Lines        1887     2032     +145     
  Branches      402      428      +26     
==========================================
+ Hits         1282     1317      +35     
- Misses        497      601     +104     
- Partials      108      114       +6     
Impacted Files Coverage Δ
..._deployment_toolbelt/profiles/local_git_handler.py 23.07% <23.07%> (ø)
...deployment_toolbelt/jobs/job_plugins_downloader.py 49.64% <23.21%> (-15.92%) ⬇️
...loyment_toolbelt/jobs/job_profiles_synchronizer.py 41.73% <37.50%> (-1.90%) ⬇️
qgis_deployment_toolbelt/plugins/plugin.py 72.72% <53.84%> (-2.09%) ⬇️
qgis_deployment_toolbelt/profiles/__init__.py 100.00% <100.00%> (ø)
...deployment_toolbelt/profiles/remote_git_handler.py 78.87% <100.00%> (ø)

@Guts Guts added the enhancement New feature or request label Apr 13, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 14, 2023
@Guts Guts requested a review from florentfgrs April 14, 2023 06:22
@Guts Guts marked this pull request as ready for review April 14, 2023 06:23
@github-actions github-actions bot added the quality Tests, project resiliency, etc. label Apr 14, 2023
Copy link
Collaborator

@florentfgrs florentfgrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved

@Guts Guts merged commit 858db0f into main Apr 14, 2023
@Guts Guts deleted the feature/local-plugins branch April 14, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request jobs Scenarios and jobs quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants