Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto: add a Git handler base class to inherit from and avoid duplicate code #333

Merged
merged 4 commits into from
Nov 11, 2023

Conversation

Guts
Copy link
Owner

@Guts Guts commented Nov 10, 2023

  • add a class GitHandlerBase and make LocalGitHandler and RemoteGitHandler inherit from to mutualize code
  • fix profiles sync which was stucked during fetch

@github-actions github-actions bot added jobs Scenarios and jobs quality Tests, project resiliency, etc. labels Nov 10, 2023
@Guts Guts self-assigned this Nov 10, 2023
@Guts Guts added enhancement New feature or request and removed jobs Scenarios and jobs enhancement New feature or request labels Nov 10, 2023
@Guts Guts force-pushed the fix/profiles-sync-stucking-fetch branch from 23cccef to 8edc289 Compare November 11, 2023 09:52
@github-actions github-actions bot added the jobs Scenarios and jobs label Nov 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2023

Codecov Report

Merging #333 (8edc289) into main (621a81f) will increase coverage by 1.52%.
The diff coverage is 72.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   64.84%   66.36%   +1.52%     
==========================================
  Files          38       39       +1     
  Lines        2119     2084      -35     
  Branches      453      442      -11     
==========================================
+ Hits         1374     1383       +9     
+ Misses        621      576      -45     
- Partials      124      125       +1     
Files Coverage Δ
...loyment_toolbelt/jobs/job_profiles_synchronizer.py 41.73% <ø> (ø)
...deployment_toolbelt/profiles/remote_git_handler.py 100.00% <100.00%> (+21.12%) ⬆️
..._deployment_toolbelt/profiles/local_git_handler.py 42.10% <30.76%> (+19.02%) ⬆️
...s_deployment_toolbelt/profiles/git_handler_base.py 75.30% <75.30%> (ø)

@Guts Guts merged commit 1643ee9 into main Nov 11, 2023
22 checks passed
@Guts Guts deleted the fix/profiles-sync-stucking-fetch branch November 11, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jobs Scenarios and jobs quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants