Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support environment variables on Linux (bash) #345

Closed
wants to merge 0 commits into from

Conversation

Guts
Copy link
Owner

@Guts Guts commented Nov 15, 2023

  • add a mechanism to check if .profile is loaded from bashrc
  • allow to remove an environment variable
  • allow to update an environment variable (idea: look for line starting swith export {env_value} then check the value following the =)
  • integrate with QDT job logic and codebase

Resources

closes #322

@Guts Guts self-assigned this Nov 15, 2023
@github-actions github-actions bot added dependencies Project dependencies. quality Tests, project resiliency, etc. labels Nov 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: Patch coverage is 79.14439% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 71.47%. Comparing base (4bd43c0) to head (1bdd626).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   70.04%   71.47%   +1.42%     
==========================================
  Files          44       45       +1     
  Lines        2474     2647     +173     
  Branches      526      570      +44     
==========================================
+ Hits         1733     1892     +159     
- Misses        573      576       +3     
- Partials      168      179      +11     
Flag Coverage Δ
unittests 70.83% <77.54%> (+1.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...loyment_toolbelt/jobs/job_environment_variables.py 79.41% <70.58%> (-1.84%) ⬇️
qgis_deployment_toolbelt/utils/linux_utils.py 81.04% <81.04%> (ø)

... and 5 files with indirect coverage changes

@github-actions github-actions bot added the jobs Scenarios and jobs label Dec 18, 2023
Copy link
Owner Author

@Guts Guts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first quick review to allow async work.

qgis_deployment_toolbelt/utils/linux_utils.py Outdated Show resolved Hide resolved
requirements/base.txt Outdated Show resolved Hide resolved
qgis_deployment_toolbelt/utils/linux_utils.py Outdated Show resolved Hide resolved
qgis_deployment_toolbelt/utils/linux_utils.py Outdated Show resolved Hide resolved
qgis_deployment_toolbelt/utils/linux_utils.py Outdated Show resolved Hide resolved
qgis_deployment_toolbelt/utils/linux_utils.py Outdated Show resolved Hide resolved
qgis_deployment_toolbelt/utils/linux_utils.py Outdated Show resolved Hide resolved
qgis_deployment_toolbelt/jobs/job_environment_variables.py Outdated Show resolved Hide resolved
qgis_deployment_toolbelt/jobs/job_environment_variables.py Outdated Show resolved Hide resolved
qgis_deployment_toolbelt/jobs/job_environment_variables.py Outdated Show resolved Hide resolved
@Guts Guts marked this pull request as ready for review December 19, 2023 15:02
@Guts Guts changed the title Feature: support environment variables on linux Feature: support environment variables on Linux (bash) Dec 19, 2023
@Guts Guts force-pushed the feature/support-environment-variables-on-linux branch from 3a60aa0 to 8172510 Compare January 10, 2024 17:31
@Guts Guts force-pushed the feature/support-environment-variables-on-linux branch from 8172510 to cdd3c41 Compare February 22, 2024 10:38
@github-actions github-actions bot added the enhancement New feature or request label Feb 22, 2024
@Guts Guts force-pushed the feature/support-environment-variables-on-linux branch 2 times, most recently from ffb079e to 65db3a7 Compare February 22, 2024 17:07
@github-actions github-actions bot added documentation Improvements or additions to documentation ci-cd Continuous integration and deployment. tooling Development tooling labels Feb 23, 2024
Repository owner deleted a comment from sonarcloud bot Feb 23, 2024
@Guts Guts closed this Feb 23, 2024
@Guts Guts force-pushed the feature/support-environment-variables-on-linux branch from 2742560 to db9bb58 Compare February 23, 2024 15:04
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Guts Guts deleted the feature/support-environment-variables-on-linux branch February 23, 2024 15:23
Guts added a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Continuous integration and deployment. dependencies Project dependencies. documentation Improvements or additions to documentation enhancement New feature or request jobs Scenarios and jobs quality Tests, project resiliency, etc. tooling Development tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Allow environment variable management under Linux
3 participants