Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: HTTP downloader refacto part 2 #372

Merged
merged 9 commits into from
Dec 29, 2023
Merged

Conversation

Guts
Copy link
Owner

@Guts Guts commented Dec 28, 2023

Following #351

@github-actions github-actions bot added quality Tests, project resiliency, etc. jobs Scenarios and jobs labels Dec 28, 2023
@Guts Guts self-assigned this Dec 28, 2023
@Guts Guts added the enhancement New feature or request label Dec 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (17105ea) 67.05% compared to head (043c21b) 66.94%.
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   67.05%   66.94%   -0.12%     
==========================================
  Files          43       43              
  Lines        2386     2423      +37     
  Branches      512      515       +3     
==========================================
+ Hits         1600     1622      +22     
- Misses        633      648      +15     
  Partials      153      153              
Files Coverage Δ
...deployment_toolbelt/jobs/job_plugins_downloader.py 48.85% <100.00%> (ø)
qgis_deployment_toolbelt/utils/file_downloader.py 86.84% <100.00%> (+0.35%) ⬆️
qgis_deployment_toolbelt/utils/formatters.py 90.90% <100.00%> (+6.29%) ⬆️
...eployment_toolbelt/profiles/remote_http_handler.py 34.32% <25.00%> (+6.82%) ⬆️

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 28, 2023
@Guts Guts force-pushed the feature/profiles-sync-http-part2 branch from a0f4ed4 to 043c21b Compare December 29, 2023 10:23
Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts merged commit 5645ad7 into main Dec 29, 2023
26 checks passed
@Guts Guts deleted the feature/profiles-sync-http-part2 branch December 29, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request jobs Scenarios and jobs quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants