Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: improve reliability of version templater making sure that a SemVer compliant version number is passed #483

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Apr 15, 2024

This PR makes it possible to have compliant SemVer versions.

@Guts Guts self-assigned this Apr 15, 2024
@github-actions github-actions bot added enhancement New feature or request packaging Making the toolbelt usable on different ways and platforms. labels Apr 15, 2024
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.06%. Comparing base (3b1cd7a) to head (7c77188).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   70.06%   70.06%           
=======================================
  Files          46       46           
  Lines        2856     2856           
  Branches      624      624           
=======================================
  Hits         2001     2001           
  Misses        670      670           
  Partials      185      185           
Flag Coverage Δ
unittests 69.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Guts Guts requested a review from jmkerloch April 15, 2024 18:23
@Guts Guts merged commit 284d624 into main Apr 15, 2024
25 checks passed
@Guts Guts deleted the improve/build-windows-version-templater-semver branch April 15, 2024 18:27
@Guts Guts removed the enhancement New feature or request label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Making the toolbelt usable on different ways and platforms.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants