Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(rules): add user name and groups to rules context #489

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Apr 19, 2024

Following up #481

   [...]
    "user": {
        "groups_domain": [],
        "groups_local": [
            "adm",
            "cdrom",
            "dip",
            "docker",
            "lpadmin",
            "lxd",
            "microk8s",
            "plugdev",
            "sambashare",
            "sudo",
            "vboxusers",
            "www-data"
        ],
        "name": "jmo"
    }

@Guts Guts self-assigned this Apr 19, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request jobs Scenarios and jobs labels Apr 19, 2024
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (80851c6) to head (3097e80).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   68.48%   70.08%   +1.60%     
==========================================
  Files          48       48              
  Lines        3011     3015       +4     
  Branches      648      648              
==========================================
+ Hits         2062     2113      +51     
+ Misses        769      718      -51     
- Partials      180      184       +4     
Flag Coverage Δ
unittests 69.45% <100.00%> (+1.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...loyment_toolbelt/jobs/job_profiles_synchronizer.py 50.79% <100.00%> (ø)
..._deployment_toolbelt/utils/computer_environment.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Guts Guts merged commit ca95ad2 into main Apr 22, 2024
26 checks passed
@Guts Guts deleted the feature/add-user-to-rules-context branch April 22, 2024 15:46
@Guts Guts linked an issue Apr 23, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request jobs Scenarios and jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: add conditions on profile deployment
2 participants