Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiles): profiles listing was returning the unfiltered list #497

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Apr 25, 2024

No description provided.

@Guts Guts marked this pull request as ready for review April 25, 2024 08:56
@github-actions github-actions bot added bug Something isn't working jobs Scenarios and jobs labels Apr 25, 2024
@Guts Guts self-assigned this Apr 25, 2024
@github-actions github-actions bot added the quality Tests, project resiliency, etc. label Apr 25, 2024
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts enabled auto-merge April 25, 2024 09:30
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.99%. Comparing base (06c0a7c) to head (cc8ca17).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   70.99%   70.99%           
=======================================
  Files          48       48           
  Lines        3086     3086           
  Branches      657      658    +1     
=======================================
  Hits         2191     2191           
  Misses        705      705           
  Partials      190      190           
Flag Coverage Δ
unittests 70.41% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
qgis_deployment_toolbelt/jobs/generic_job.py 89.15% <100.00%> (ø)

@Guts Guts merged commit 5309317 into main Apr 25, 2024
25 checks passed
@Guts Guts deleted the fix/profiles-listing-was-returning-unfiltered-list branch April 25, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jobs Scenarios and jobs quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants