Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(user_groups): enforces user domain groups retrieval using user guid #508

Merged

Conversation

Guts
Copy link
Owner

@Guts Guts commented May 29, 2024

Closes #506

@github-actions github-actions bot added the enhancement New feature or request label May 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 70.69%. Comparing base (f914df6) to head (839d5a8).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   70.59%   70.69%   +0.09%     
==========================================
  Files          48       48              
  Lines        3054     3078      +24     
  Branches      658      662       +4     
==========================================
+ Hits         2156     2176      +20     
- Misses        708      711       +3     
- Partials      190      191       +1     
Flag Coverage Δ
unittests 70.07% <72.41%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
qgis_deployment_toolbelt/utils/user_groups.py 64.61% <75.86%> (+4.23%) ⬆️

@Guts Guts force-pushed the improve/enforcing-user-domain-groups-retrieval-using-user-guid branch from 46fda45 to 839d5a8 Compare May 29, 2024 13:17
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts merged commit dbed6b7 into main May 29, 2024
25 checks passed
@Guts Guts deleted the improve/enforcing-user-domain-groups-retrieval-using-user-guid branch May 29, 2024 13:24
@Guts Guts added this to the 0.34.3 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: export-rules-context sur Windows
2 participants