Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(downloader): add option to control over stream mode #541

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Sep 2, 2024

This PR introduces a new option QDT_STREAMED_DOWNLOADS to control over stream mode for file downloader. By default, files are streamed but it can lead to some errors. This setting helps to avoid buggy behaviors.

@Guts Guts self-assigned this Sep 2, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request quality Tests, project resiliency, etc. labels Sep 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.14%. Comparing base (240d9f2) to head (a660b08).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
qgis_deployment_toolbelt/utils/file_downloader.py 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   71.08%   71.14%   +0.06%     
==========================================
  Files          47       47              
  Lines        3081     3091      +10     
  Branches      664      666       +2     
==========================================
+ Hits         2190     2199       +9     
  Misses        700      700              
- Partials      191      192       +1     
Flag Coverage Δ
unittests 70.52% <86.66%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
qgis_deployment_toolbelt/commands/deployment.py 70.58% <100.00%> (+0.43%) ⬆️
qgis_deployment_toolbelt/commands/upgrade.py 62.63% <ø> (ø)
...deployment_toolbelt/jobs/job_plugins_downloader.py 50.75% <100.00%> (+0.75%) ⬆️
...eployment_toolbelt/profiles/remote_http_handler.py 36.53% <100.00%> (+2.53%) ⬆️
qgis_deployment_toolbelt/utils/file_downloader.py 75.51% <80.00%> (+0.51%) ⬆️

@github-actions github-actions bot added the jobs Scenarios and jobs label Sep 2, 2024
Copy link

sonarcloud bot commented Sep 2, 2024

@Guts Guts merged commit f67df6d into main Sep 2, 2024
26 checks passed
@Guts Guts deleted the feature/add-option-to-control-streamed-downloading branch September 2, 2024 09:09
@Guts Guts added this to the 0.34.5 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request jobs Scenarios and jobs quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants