Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(downloader): add option to disable SSL verification #544

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Sep 2, 2024

No description provided.

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 2, 2024
@Guts Guts force-pushed the feature/add-disabled-ssl-mode branch from 674c294 to 4157539 Compare September 2, 2024 14:21
Copy link

sonarcloud bot commented Sep 2, 2024

@Guts Guts enabled auto-merge September 2, 2024 14:22
@Guts Guts self-assigned this Sep 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.08%. Comparing base (92a8472) to head (4157539).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
qgis_deployment_toolbelt/utils/file_downloader.py 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
- Coverage   71.12%   71.08%   -0.05%     
==========================================
  Files          46       46              
  Lines        3089     3095       +6     
  Branches      665      666       +1     
==========================================
+ Hits         2197     2200       +3     
- Misses        699      701       +2     
- Partials      193      194       +1     
Flag Coverage Δ
unittests 70.50% <57.14%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
qgis_deployment_toolbelt/utils/file_downloader.py 72.72% <57.14%> (-2.79%) ⬇️

@Guts Guts merged commit dad8681 into main Sep 2, 2024
26 checks passed
@Guts Guts deleted the feature/add-disabled-ssl-mode branch September 2, 2024 14:25
@Guts Guts added this to the 0.35.1 milestone Sep 4, 2024
Guts added a commit that referenced this pull request Sep 4, 2024
…ough injection (#549)

This PR follows up:

- #544
- #444

It improve how system's store certificates are used, preferring a custom
HTTP adapter to the SSL injection.

It's mainly inspired from https://stackoverflow.com/a/78265028/2556577.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants