MaterialComboBox.setSingleValue fires ValueChangeEvent with wrong values

[gkresic]

Looking at MaterialComboBox.setSingleValue(T, boolean) isn't it wrong to use values as new value (values contains all possible items in combo, not newly selected one)? Shouldn't it be something like Collections.singletonList(value)?

[kevzlou7979]

I've tried to update the method you proposed but it causing a major issue on ComboBox now.

public void setSingleValue(T value, boolean fireEvents) {
        int index = this.values.indexOf(Collections.singletonList(value));
        if (index >= 0) {
            List<T> before = getValue();
            setSelectedIndex(index);

            if (fireEvents) {
                ValueChangeEvent.fireIfNotEqual(this, before, values);
            }
        }
    }

[gkresic]

It's been a while, but if I remember correctly, change was not necessary in #471:

int index = this.values.indexOf(value);

but at #477 where event fires:

ValueChangeEvent.fireIfNotEqual(this, before, Collections.singletonList(value));

[kevzlou7979]

Oops yeah, thanks for this update. I will try to check if something is breaking up on unit tests. If there's nothing then I can patch this up to 2.0.1

[kevzlou7979]

Updated the fix f0fbb27