Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swedish translation #213

Merged
merged 4 commits into from
May 26, 2023
Merged

Swedish translation #213

merged 4 commits into from
May 26, 2023

Conversation

vcrn
Copy link
Contributor

@vcrn vcrn commented May 22, 2023

This PR is to add Swedish as a language option, as requested in Issue #60.

There's one thing that needs to be fixed though, and one to be discussed:

  • The letters Ä, Å and å can't be displayed, they only result in a white space. I've added these to resources/fonts/full/subset_characters.txt, but the issue persists, so I'm not sure what the cause is. Is there a certain order in which they need to be placed? Because now, I've put them in arbitrary locations in subset_characters.txt.
  • I started out by creating a 4th column for Swedish in the language selection page, but it became a bit cramped with 4 columns, so I went with adding it to the 1st column. Does this, and the placement, seem alright with you?

I've also made (what seems to me to be) some small corrections of other texts.

@GyulyVGC GyulyVGC added the translation User interface translation label May 22, 2023
@GyulyVGC
Copy link
Owner

Hi @vcrn thank you very much.

For point 1): don't worry, I'll fix it personally. (It's also necessary to include those letters in the font file but I use a program to do it, so don't worry of doing it yourself).

For point 2): I'll fix it as well!

@GyulyVGC
Copy link
Owner

Update:

  • added missing characters to the font files
  • restructured language selection page
  • renamed Swedish language code to SV (SE is the code for Sweden, the country)

If you confirm everything looks good to you as well, I'll proceed merging

@vcrn
Copy link
Contributor Author

vcrn commented May 24, 2023

Great, I'll check it out today or tomorrow!

@vcrn
Copy link
Contributor Author

vcrn commented May 25, 2023

Everything looks alright to me save for one thing that I want to bring up.

I noticed when running Sniffnet on another computer where the resolution and text size is different, that the text "Applikationsprotokoll" has a tendency to be cut off if I either only use the laptop's screen or if I don't have Sniffnet on fullscreen on on the external monitor. It looks like the person doing the German translation noticed the same thing and went with the German equivalent of "Applikations-protokoll", even though a hyphen isn't supposed to be there either if it's written on one line. In Latex, you can use \- to indicate that if a line-break with a hyphen is suitable, it should be placed there, but I haven't found any similar thing in this case.

Can you run it with Swedish settings and have a look? What's your opinion on this, do you think most people will need a line-break there and that we should include it, in case we don't have an option similar to \-?

Also, I noticed that I forgot to include Å in subset_characters.txt, but it is never used anywhere so it's fine.

@GyulyVGC
Copy link
Owner

GyulyVGC commented May 25, 2023

The library I use for the GUI has a very basic text handling as of today so I don't think it supports a similar feature.

After having played a bit with the relative widths of the filter columns I have come up with sizes that correctly display all the columns title in one line without cuts, in all the currently available languages.
Thank you very much for having pointed out the problem (I noticed it happened for Korean as well).
Confirm everything's good when you can.

PS: you didn't forget the Å actually, I removed it by editing that file, grepping all the used characters in the src folder.

@vcrn
Copy link
Contributor Author

vcrn commented May 26, 2023

Great, now it looks good in full-screen on both laptop screens! To me it's fine to be merged

@GyulyVGC GyulyVGC merged commit bf0205a into GyulyVGC:main May 26, 2023
@GyulyVGC
Copy link
Owner

@all-contributors please add @vcrn for translation.

@allcontributors
Copy link
Contributor

@GyulyVGC

I've put up a pull request to add @vcrn! 🎉

@vcrn
Copy link
Contributor Author

vcrn commented May 26, 2023

@all-contributors please add @vcrn for translation.

Thanks, appreciate it!

I'll see if there's something else I can help out with. Right now I'm looking into what makes one of my laptops running Manjaro able to display the flag-icons using wgpu, while my laptop that runs Arch can only do it using glow. Will see if it's due to hardware or some missing dependency

@allcontributors
Copy link
Contributor

@vcrn

@vcrn already contributed before to translation

@GyulyVGC
Copy link
Owner

Thanks, appreciate it!

I'll see if there's something else I can help out with. Right now I'm looking into what makes one of my laptops running Manjaro able to display the flag-icons using wgpu, while my laptop that runs Arch can only do it using glow. Will see if it's due to hardware or some missing dependency

I must be thanking you man!
I think that problem is "normal", Iced documented it a lot and suggests to use glow in case of problems.
However, they are introducing a new software renderer that should be "universal" (but someone already reported on their Discord that in some cases this bug happens as well)

@GyulyVGC GyulyVGC added this to the v1.2.1 milestone Jun 1, 2023
@vcrn
Copy link
Contributor Author

vcrn commented Jun 4, 2023

I must be thanking you man! I think that problem is "normal", Iced documented it a lot and suggests to use glow in case of problems. However, they are introducing a new software renderer that should be "universal" (but someone already reported on their Discord that in some cases this bug happens as well)

Cool, I'll check it out!

In case it's of any interest, my laptop that could display the icons while running Manjaro can still display them after a fresh install of Arch, so it seems like it's something on the hardware level that is making my other Arch laptop unable to display them.

@GyulyVGC
Copy link
Owner

GyulyVGC commented Jun 4, 2023

Yep, absolutely.
I forgot to mention that this problem usually has to do with the graphical card / adapter of the machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation User interface translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants