-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swedish translation #213
Swedish translation #213
Conversation
Hi @vcrn thank you very much. For point 1): don't worry, I'll fix it personally. (It's also necessary to include those letters in the font file but I use a program to do it, so don't worry of doing it yourself). For point 2): I'll fix it as well! |
Update:
If you confirm everything looks good to you as well, I'll proceed merging |
Great, I'll check it out today or tomorrow! |
Everything looks alright to me save for one thing that I want to bring up. I noticed when running Sniffnet on another computer where the resolution and text size is different, that the text "Applikationsprotokoll" has a tendency to be cut off if I either only use the laptop's screen or if I don't have Sniffnet on fullscreen on on the external monitor. It looks like the person doing the German translation noticed the same thing and went with the German equivalent of "Applikations-protokoll", even though a hyphen isn't supposed to be there either if it's written on one line. In Latex, you can use Can you run it with Swedish settings and have a look? What's your opinion on this, do you think most people will need a line-break there and that we should include it, in case we don't have an option similar to Also, I noticed that I forgot to include |
The library I use for the GUI has a very basic text handling as of today so I don't think it supports a similar feature. After having played a bit with the relative widths of the filter columns I have come up with sizes that correctly display all the columns title in one line without cuts, in all the currently available languages. PS: you didn't forget the |
Great, now it looks good in full-screen on both laptop screens! To me it's fine to be merged |
@all-contributors please add @vcrn for translation. |
I've put up a pull request to add @vcrn! 🎉 |
Thanks, appreciate it! I'll see if there's something else I can help out with. Right now I'm looking into what makes one of my laptops running Manjaro able to display the flag-icons using |
I must be thanking you man! |
Cool, I'll check it out! In case it's of any interest, my laptop that could display the icons while running Manjaro can still display them after a fresh install of Arch, so it seems like it's something on the hardware level that is making my other Arch laptop unable to display them. |
Yep, absolutely. |
This PR is to add Swedish as a language option, as requested in Issue #60.
There's one thing that needs to be fixed though, and one to be discussed:
Ä
,Å
andå
can't be displayed, they only result in a white space. I've added these toresources/fonts/full/subset_characters.txt
, but the issue persists, so I'm not sure what the cause is. Is there a certain order in which they need to be placed? Because now, I've put them in arbitrary locations insubset_characters.txt
.I've also made (what seems to me to be) some small corrections of other texts.