ie s2s rules #14
Merged
ie s2s rules #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myromeu
commented
Feb 8, 2024
| func accPortsRangeFromTF(ctx context.Context, tfValue types.List, dst *[]AccessPorts) (diags diag.Diagnostics) { | ||
| diags.Append(tfValue.ElementsAs(ctx, dst, false)...) | ||
| if diags.HasError() { | ||
| return diags | ||
| } | ||
| // this conversion necessary to validate string with ports | ||
| if _, err := toModelPorts(*dst); err != nil { | ||
| if _, err := toModelPorts(*dst); err != nil { // TODO: эта проверка вообще лишняя |
There was a problem hiding this comment.
эта проверка нужна чтобы в методах SingleResource.IsDiffer не обрабатывать ошибку
раньше эта проверка была в каждом методе sync для ресурсов - я решил вынести чтобы не забывать его писать
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.