Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naybrees code side #1228

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

Traveler263
Copy link

This is the corresponding Plasma Side to Eder Naybree Age- containing all the .age, .fni, etc that's needed to get Naybree Working.

@@ -0,0 +1,8 @@
from Plasma import *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the GPL license block as found in the other Python files. Check this as an example: https://github.com/H-uru/Plasma/blob/master/Scripts/Python/Ahnonay.py#L1:L42

VAR BOOL ExtcolBookVis[1] DEFAULT=0 DEFAULTOPTION=VAULT
VAR BOOL RewardKelsFleeceVis[1] DEFAULT=0 DEFAULTOPTION=VAULT
VAR BOOL YeeshaPageNBVis[1] DEFAULT=0 DEFAULTOPTION=VAULT
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline at EOF, please.

@@ -0,0 +1,27 @@
STATEDESC EderNaybree
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the GPL license block as found in the other SDL files. Check this as an example: https://github.com/H-uru/Plasma/blob/master/Scripts/SDL/BaronCityOffice.sdl#L1:L41

Comment on lines 4 to 7
VAR AGETIMEOFDAY AthsDayNight01[1]
VAR BOOL VCatBookVis[1] DEFAULT=0 DEFAULTOPTION=VAULT
VAR BOOL ExtcolBookVis[1] DEFAULT=0 DEFAULTOPTION=VAULT
VAR BOOL RewardKelsFleeceVis[1] DEFAULT=0 DEFAULTOPTION=VAULT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would appreciate all of the fields in the SDL file to be vertically aligned, like so:

Suggested change
VAR AGETIMEOFDAY AthsDayNight01[1]
VAR BOOL VCatBookVis[1] DEFAULT=0 DEFAULTOPTION=VAULT
VAR BOOL ExtcolBookVis[1] DEFAULT=0 DEFAULTOPTION=VAULT
VAR BOOL RewardKelsFleeceVis[1] DEFAULT=0 DEFAULTOPTION=VAULT
VAR AGETIMEOFDAY AthsDayNight01[1]
VAR BOOL VCatBookVis[1] DEFAULT=0 DEFAULTOPTION=VAULT
VAR BOOL ExtcolBookVis[1] DEFAULT=0 DEFAULTOPTION=VAULT
VAR BOOL RewardKelsFleeceVis[1] DEFAULT=0 DEFAULTOPTION=VAULT

@dpogue dpogue added the Content Pull Requests related to game content label Sep 10, 2022
synch with current from Minkata/Staging.
or will be once staging is brought to current.
Adds Music Canen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Pull Requests related to game content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants