Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kalamee Q1 2023 #1283

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Kalamee Q1 2023 #1283

wants to merge 7 commits into from

Conversation

DoobesURU
Copy link
Contributor

  • Adds scripting files for Age of Kalamee by Semjay and Cyan, Inc.
  • Updates xLinkingBookDefs.py with definition for Kalamee.

Note that the second part was a separate commit in case one wants to cherry pick for testing or in case I need to roll back to keep from conflicting with other PRs.

Semjay and others added 2 commits December 28, 2022 15:20
* Adds AGE, FNI, PY and SDL files for Age of Kalamee by Semjay and Cyan
* Adds definitions for Kalamee to xLinkingBookDefs.py script
@Hoikas
Copy link
Member

Hoikas commented Dec 28, 2022

---ERROR Scripts/Python/KalameeResetJC.py:48 ModuleNotFoundError: No module named 'xEnum'---

* H'uru-fy script per dpogue's suggestions
* Carry over Offline KI scripts xMultiDialogToggle.py and xSimplePanel.py for Kalamee
* Add new Chiso lower floor Link in definition for Kalamee (and any future uses)
@Hoikas
Copy link
Member

Hoikas commented Jan 21, 2023

Breaks TL deployment

 Traceback (most recent call last):
  File "Scripts/Tests/xGamePythonReview.py", line 169, in <module>
    spec.loader.exec_module(mod)
  File "<frozen importlib._bootstrap_external>", line 843, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/runner/work/Plasma/Plasma/Scripts/Python/clftGetPersonalBook.py", line 56, in <module>
    import xLinkingBookDefs
  File "/home/runner/work/Plasma/Plasma/Scripts/Python/xLinkingBookDefs.py", line 271, in <module>
    "ChisoPrenivLower":     ( 0, 1.0, 1.0, NoDRCStamp, BookStart + DRCStampHolder + NoShare + LinkStart + 'xlinkpanelchisolower' + LinkEnd ),
NameError: name 'BookStart' is not defined

@DoobesURU
Copy link
Contributor Author

Breaks TL deployment

 Traceback (most recent call last):
  File "Scripts/Tests/xGamePythonReview.py", line 169, in <module>
    spec.loader.exec_module(mod)
  File "<frozen importlib._bootstrap_external>", line 843, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/runner/work/Plasma/Plasma/Scripts/Python/clftGetPersonalBook.py", line 56, in <module>
    import xLinkingBookDefs
  File "/home/runner/work/Plasma/Plasma/Scripts/Python/xLinkingBookDefs.py", line 271, in <module>
    "ChisoPrenivLower":     ( 0, 1.0, 1.0, NoDRCStamp, BookStart + DRCStampHolder + NoShare + LinkStart + 'xlinkpanelchisolower' + LinkEnd ),
NameError: name 'BookStart' is not defined

Oops! BookStart vs the proper BookStart1. 😊 My bad! New commit should fix that.

@Hoikas
Copy link
Member

Hoikas commented Feb 12, 2023

(02/11 20:29:44) PythonFile02 - Traceback (most recent call last):
(02/11 20:29:44)   File "xMultiDialogToggle.py", line 134, in OnNotify
(02/11 20:29:44)   File "xMultiDialogToggle.py", line 174, in IStartDialog
(02/11 20:29:44) NameError: name 'true' is not defined. Did you mean: 'True'?
(02/11 20:29:58) xMultiDialogToggle: Dialog SketchbookA goes down
(02/11 20:29:58) PythonFile02 - Traceback (most recent call last):
(02/11 20:29:58)   File "xMultiDialogToggle.py", line 155, in OnGUINotify
(02/11 20:29:58)   File "xMultiDialogToggle.py", line 186, in IQuitDialog
(02/11 20:29:58) NameError: name 'false' is not defined. Did you mean: 'False'?

Scripts/Python/xMultiDialogToggle.py Outdated Show resolved Hide resolved
Scripts/Python/xMultiDialogToggle.py Outdated Show resolved Hide resolved
Scripts/Python/xMultiDialogToggle.py Outdated Show resolved Hide resolved
Scripts/Python/xMultiDialogToggle.py Outdated Show resolved Hide resolved
Scripts/Python/xMultiDialogToggle.py Outdated Show resolved Hide resolved
Scripts/Python/xMultiDialogToggle.py Outdated Show resolved Hide resolved
Scripts/Python/xMultiDialogToggle.py Outdated Show resolved Hide resolved
Scripts/Python/xMultiDialogToggle.py Outdated Show resolved Hide resolved
Scripts/Python/xMultiDialogToggle.py Outdated Show resolved Hide resolved
Scripts/Python/xMultiDialogToggle.py Outdated Show resolved Hide resolved
@DoobesURU
Copy link
Contributor Author

Heh, sorry for the silence. Y'all have been diligent in finding the bugs and I've been slacking at committing them. 😊

I'll get to this after work today...assuming I'm not too brain-fried by then!

Suggested fixes per @ZarothYe.

Co-authored-by: Zaroth <94947971+ZarothYe@users.noreply.github.com>
@dpogue dpogue added the Content Pull Requests related to game content label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Pull Requests related to game content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants