Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds SDL based upload check for imagers #1458

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

Hazado
Copy link
Contributor

@Hazado Hazado commented Aug 10, 2023

Assets - H-uru/moul-assets#241
Sets up the an SDL variable so you can set individual permissions for upload/pellet drops to everyone/member only/off

Requested by Cyan Shard operator to prevent pellet uploads in individual hoods

Adds new SDL variable to Neighborhood.sdl
nb01PelletUploadState

0 <= Everyone can upload (Default)
1 = Members only upload
2 >= No one can upload

Sets up the an SDL variable so you can set individual pellet uploads to everyone/member only/off
@Hazado Hazado force-pushed the PelletDonationVariableCheck branch from 2e7a036 to 471494a Compare August 10, 2023 18:35
@dgelessus
Copy link
Contributor

Relatively minor thing: the code looks like it would work for all imagers that pop up in the KI, not just the pellet imager. Perhaps the things in the script should be called ImagerPermissionVariable, CheckPermission, etc. instead, in case we later want to add permission checks to other imagers as well?

@Hazado
Copy link
Contributor Author

Hazado commented Aug 10, 2023

Relatively minor thing: the code looks like it would work for all imagers that pop up in the KI, not just the pellet imager. Perhaps the things in the script should be called ImagerPermissionVariable, CheckPermission, etc. instead, in case we later want to add permission checks to other imagers as well?

Your absolutely right, change made.

@Hazado Hazado changed the title Adds pellet upload check Adds SDL based upload check for imagers Aug 10, 2023
Scripts/Python/xSimpleImager.py Outdated Show resolved Hide resolved
Scripts/SDL/Neighborhood.sdl Outdated Show resolved Hide resolved
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
@Hazado Hazado requested a review from Hoikas August 11, 2023 16:52
@Hoikas Hoikas added the Blocking on MOULa This pull request is accepted but is blocking on an analogous deployment to Cyan's MOULa Shard. label Aug 13, 2023
@Hoikas
Copy link
Member

Hoikas commented Aug 13, 2023

As of #1450, we could theoretically merge this immediately without breaking MOULa. However, I think there's probably a discussion to be had about what our repository's SDL should look like compared to the rest of the ecosystem, so we should probably wait until either after that discussion or the SDL is deployed to MOULa.

@Hoikas Hoikas removed the Blocking on MOULa This pull request is accepted but is blocking on an analogous deployment to Cyan's MOULa Shard. label Nov 10, 2023
Scripts/Python/xSimpleImager.py Outdated Show resolved Hide resolved
Scripts/Python/xSimpleImager.py Outdated Show resolved Hide resolved
@Hoikas Hoikas merged commit e7af4c6 into H-uru:master Nov 10, 2023
15 checks passed
@Hazado Hazado deleted the PelletDonationVariableCheck branch December 1, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants