Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self patching Mac application #1528

Merged
merged 32 commits into from
Jul 28, 2024
Merged

Self patching Mac application #1528

merged 32 commits into from
Jul 28, 2024

Commits on Jun 17, 2024

  1. Self patching Mac application

    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8cedeec View commit details
    Browse the repository at this point in the history

  2. Feedback from code review

    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    be038c2 View commit details
    Browse the repository at this point in the history

  3. Externalizing Mac bundle executable finding

    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    eb84009 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: dgelessus <dgelessus@users.noreply.github.com>
    @colincornaby @dgelessus
    colincornaby and dgelessus committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    0367fa7 View commit details
    Browse the repository at this point in the history

  5. Handling self patch copy errors

    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    76f6e52 View commit details
    Browse the repository at this point in the history

  6. Cleaning up exit calls in decompression function

    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    dfb4750 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: dgelessus <dgelessus@users.noreply.github.com>
    @colincornaby @dgelessus
    colincornaby and dgelessus committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    6afdf95 View commit details
    Browse the repository at this point in the history

  8. Constraining archive types to tar/gzip/bzip

    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    783df85 View commit details
    Browse the repository at this point in the history

  9. Code cleanup in Mac client patching

    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4a3cdac View commit details
    Browse the repository at this point in the history

  10. Fixing renamex_np error handling

    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    29cf9fd View commit details
    Browse the repository at this point in the history

  11. Apply suggestions from code review 

    Co-authored-by: dgelessus <dgelessus@users.noreply.github.com>
    @colincornaby @dgelessus
    colincornaby and dgelessus committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    418c28d View commit details
    Browse the repository at this point in the history

  12. Adding feedback from code review 

    Co-authored-by: dgelessus <dgelessus@users.noreply.github.com>
    @colincornaby @dgelessus
    colincornaby and dgelessus committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9593e8f View commit details
    Browse the repository at this point in the history

  13. Adding missing import

    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    0ac9d8d View commit details
    Browse the repository at this point in the history

  14. Adding guard against temp directory create failure 

    createDirectoryAtURL technically is not supposed to take a nil value - guard against this.
    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2a216e2 View commit details
    Browse the repository at this point in the history

  15. Moving variables into while loop

    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    857f056 View commit details
    Browse the repository at this point in the history

  16. Adding error handling for libarchive options

    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ab84e40 View commit details
    Browse the repository at this point in the history

  17. Updating permissions for Mac patcher 

    Removing ARCHIVE_EXTRACT_PERM, adding ARCHIVE_EXTRACT_OWNER, adding ARCHIVE_EXTRACT_XATTR
    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    6d45c88 View commit details
    Browse the repository at this point in the history

  18. Updating xib deployment target 

    It was not set to match the project
    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    666df02 View commit details
    Browse the repository at this point in the history

  19. Fixing delegate conformance 

    Patcher window controller is a second level delegate - but the signature changed on the completed handler.
    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    5d111b9 View commit details
    Browse the repository at this point in the history

  20. Reducing required flags 

    Following the WoW client’s lead - going to allow files to inherit owner of the user running the application - but the file permissions should be maintained. Could manually 777 everything - but for now we’ll let the tarfile set that.

Technically this could cause issues as the permissions of what the installer wrote and what is on disk may diverge - but that won’t effect functionality - only “repair permissions” scans.
    @colincornaby
    colincornaby committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d36917d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Update Sources/Plasma/FeatureLib/pfPatcher/pfPatcher.cpp 

    Co-authored-by: Darryl Pogue <darryl@dpogue.ca>
    @colincornaby @dpogue
    colincornaby and dpogue committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    f734138 View commit details
    Browse the repository at this point in the history

  2. Updating libarchive target include

    @colincornaby
    colincornaby committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    50f7d3d View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Fixing client not terminating on patch error

    @colincornaby
    colincornaby committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    5d83030 View commit details
    Browse the repository at this point in the history

  2. Passing error string through to NSError

    @colincornaby
    colincornaby committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b0ef218 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Adding executable suffix

    @colincornaby
    colincornaby committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ab6d0b4 View commit details
    Browse the repository at this point in the history

  2. Fixes for self patch 

    Deleting entire temporary directory. Also removing redundant unlink - it was causing problems because the unlinked app was getting swapped into the temporary directory.
    @colincornaby
    colincornaby committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ea2c595 View commit details
    Browse the repository at this point in the history

  3. Cleaning up executable suffix code

    @colincornaby
    colincornaby committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    f82cf31 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Style cleanup

    @colincornaby
    colincornaby committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    9d5e76f View commit details
    Browse the repository at this point in the history

  2. Removing custom LibArchive check

    @colincornaby
    colincornaby committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    6045bf8 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
    @colincornaby @Hoikas
    colincornaby and Hoikas authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    dcd06d9 View commit details
    Browse the repository at this point in the history

  2. Cleaning up leak on error

    @colincornaby
    colincornaby committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1e4cb16 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
    @colincornaby @Hoikas
    colincornaby and Hoikas authored Jul 14, 2024
    Configuration menu
    Copy the full SHA
    7dc5c44 View commit details
    Browse the repository at this point in the history