Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindPhysX should search specific lib names first #1598

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Jul 6, 2024

This resolves an issue where PhysX libraries installed with generic names at a system level were being found preferentially ahead of the ones created by vcpkg.

@Hoikas
Copy link
Member

Hoikas commented Jul 6, 2024

Have you tried modifying the find_library() calls to pass the NO_SYSTEM_ENVIRONMENT_PATH argument instead?

@dpogue
Copy link
Member Author

dpogue commented Jul 6, 2024

Have you tried modifying the find_library() calls to pass the NO_SYSTEM_ENVIRONMENT_PATH argument instead?

But we'd only want to do that if USE_VCPKG is set, right?

@Hoikas
Copy link
Member

Hoikas commented Jul 6, 2024

It looks like the find module is testing if(VCPKG_TOOLCHAIN) in places.

@dpogue
Copy link
Member Author

dpogue commented Jul 6, 2024

Okay, will give that a shot

This resolves an issue where PhysX libraries installed with generic
names at a system level were being found preferentially ahead of the
ones created by vcpkg.
@dpogue
Copy link
Member Author

dpogue commented Jul 8, 2024

Updated and seems to be working

@dpogue dpogue merged commit f405924 into H-uru:master Jul 9, 2024
17 checks passed
@dpogue dpogue deleted the physx-find-order branch July 9, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants