Add Warp Message node. #190
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
reviewed
Jul 24, 2020
| ("receivers", { | ||
| "text": "Send To", | ||
| "type": "PlasmaWarpMessageSocket", | ||
| "valid_link_sockets": {"PlasmaWarpMessageSocket", "PlasmaNodeSocketInputGeneral"}, |
There was a problem hiding this comment.
After the explanation in IRC, it might be better to use valid_link_nodes instead and specify the expected node type.
| msg = plWarpMsg() | ||
| msg.BCastFlags |= plMessage.kNetPropagate | ||
| msg.warpFlags |= plWarpMsg.kFlushTransform | ||
| msg.transform = utils.matrix44(self.pos_object.matrix_local) |
There was a problem hiding this comment.
I think this would be more useful if pos_object were optional and defaulted to the pose of the object the tree is attached to.
There was a problem hiding this comment.
That's a useful default. I'll give it a try and see how that works in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Warp Message node for use in advanced logic trees.
This node requires an object position, and sends a message to warp there to the object specified by a
PlasmaSceneObjectMsgRcvrNode.