Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha Vertex Blend Toggle #258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DoobesURU
Copy link
Contributor

Adds a per-layer toggle just below the opacity slider to use the Alpha VCol values and blend the texture. Still needs sanity checks.

@DoobesURU DoobesURU marked this pull request as draft June 26, 2021 20:33
@DoobesURU DoobesURU force-pushed the AlphaVcolTexture branch 2 times, most recently from 3b35ec7 to 18b6419 Compare August 4, 2021 22:31
Adds a per-layer toggle to use the Alpha VCol values and blend the texture
@DoobesURU DoobesURU marked this pull request as ready for review February 6, 2022 01:23
Forgot to add this earlier
@DoobesURU
Copy link
Contributor Author

Just curious if we need anything else added/subtracted from this to get 'er out the door or if the approach is too troublesome.

@Hoikas
Copy link
Member

Hoikas commented Feb 14, 2022

I wanted to spend some time trying to understand how all this works and if there's a better way to expose what's going in.

@DoobesURU
Copy link
Contributor Author

I wanted to spend some time trying to understand how all this works and if there's a better way to expose what's going in.

Ah, I understand. Like I had said before, the AlphaBlends are an odd bit of business.

@DoobesURU
Copy link
Contributor Author

Just to revive this discussion, perhaps it'd be better to use the method that (eep) PyPRP utilized, ie when there's an "Alpha" vertex color, it's used on every layer after the first? That way, it's not quite as exposed as a direct toggle, but the downside would be the end user would lose a bit of control as to which textures would receive the alpha.

Unless maybe we tie it to the existing texture_slot.use_map_alpha toggle? And anything with that on plus the Alpha VCol would get the blending?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants