Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Remove impl Default for Sink #279

Merged
merged 1 commit into from
Feb 2, 2025
Merged

💥 Remove impl Default for Sink #279

merged 1 commit into from
Feb 2, 2025

Conversation

H1rono
Copy link
Owner

@H1rono H1rono commented Feb 2, 2025

close #277

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.59%. Comparing base (4e0baff) to head (8118b99).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/handler.rs 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (69.59%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   69.59%   69.59%           
=======================================
  Files          17       17           
  Lines        1812     1812           
=======================================
  Hits         1261     1261           
  Misses        551      551           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H1rono H1rono merged commit 98db505 into main Feb 2, 2025
4 of 6 checks passed
@H1rono H1rono deleted the remove-sink-impl branch February 2, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default for Sink消す
1 participant