Add 4MB variant for Makerfabs ESP32 TFT Touch #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvanroie
reviewed
Jul 16, 2023
fvanroie
approved these changes
Jul 16, 2023
My Makerfabs ESP32 TFT Touch, v1.1 on the silkscreen, purchased in October 2020, has a 4MB flash as reported by esptool flash_id: Manufacturer: 20 Device: 4016 Detected flash size: 4MB Add a makerfabs-tft35-cap_4MB variant, and rename makerfabs-tft35-cap to makerfabs-tft35-cap_16MB.
|
The 8/16MB issue has been fixed, so this is ready to go I think. |
fvanroie
approved these changes
Jul 16, 2023
|
Great, thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Makerfabs ESP32 TFT Touch, v1.1 on the silkscreen, purchased in October 2020, has a 4MB flash as reported by esptool flash_id:
Manufacturer: 20
Device: 4016
Detected flash size: 4MB
Add a makerfabs-tft35-cap_4MB variant, and rename makerfabs-tft35-cap to makerfabs-tft35-cap_16MB.