Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HTTPS requests #643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sgruby
Copy link

@sgruby sgruby commented Feb 16, 2024

This adds the ability for img.src to use https requests. It ignores certificates validation, but allows those using Home Assistant with https to get images delivered to the boards.

Note that https requires

platform = espressif32@5.3.0

or similar to work properly.

@fvanroie
Copy link
Collaborator

There is no room on the partition to install espressif32@5.3.0, more investigation is needed.

@sgruby
Copy link
Author

sgruby commented Feb 17, 2024

I suspect TLS/SSL doesn't work in other parts of the code (I.e. mqtt or the update from a URL) without either moving forward with the platform or moving backwards. The 2023.07.00 tasmota release appears to be the last one that HTTPS worked for me.

@fvanroie
Copy link
Collaborator

Moving forward likely means dropping OTA support for 4MB boards.
Moving backwards is hardly an option since it just makes the problem and work to be done worse.

@sgruby
Copy link
Author

sgruby commented Feb 17, 2024

It’s too bad that boards are still being made with 4MB of flash. Some of the Elecrow devices only have that.

Could one option be to not allow OTA updates for devices with 4MB of flash or does the web flasher work in the same manner requiring twice the app size for flashing?

@fvanroie fvanroie added the architecture Changes to the underlying hardware or software architecture label Feb 28, 2024
@hmorkemo
Copy link

@sgruby Great feature! At some point in time we have to leave the older, smaller configurations (4MB etc) in order to move onwards.
This feature is important, and will extend the versatility of OpenHASP by a lot!

@fvanroie
Copy link
Collaborator

Dropping support for 4MB devices isn't really an option as some of the popular devices have 4MB and new products are still being launched with 4MB...

fvanroie pushed a commit that referenced this pull request Aug 31, 2024
LarsMichelsen pushed a commit to LarsMichelsen/openHASP that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Changes to the underlying hardware or software architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants