Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add --normalize-betas option #299

Merged
merged 3 commits into from
Mar 11, 2020
Merged

Conversation

jdkent
Copy link
Member

@jdkent jdkent commented Mar 10, 2020

Summary

Fixes #281 .

List of changes proposed in this PR (pull-request)

  • add --normalize-betas option

@jdkent
Copy link
Member Author

jdkent commented Mar 10, 2020

Hi @michaelmack,

here is the pull request, to normalize the betas (e.g., return t statistics as opposed to raw estimates). If would like you may review it before I merge it into the master branch.

I will cut a release after one more pull request (v0.5.0)

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #299 into master will increase coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   89.85%   90.01%   +0.15%     
==========================================
  Files          10       10              
  Lines         759      771      +12     
  Branches      115      116       +1     
==========================================
+ Hits          682      694      +12     
  Misses         45       45              
  Partials       32       32

Copy link

@michaelmack michaelmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@jdkent jdkent merged commit 6a1cd22 into HBClab:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output normalized betaseries
2 participants