Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 8 fix #315

Merged
merged 2 commits into from
Sep 26, 2017
Merged

Node 8 fix #315

merged 2 commits into from
Sep 26, 2017

Conversation

lipp
Copy link
Contributor

@lipp lipp commented Sep 26, 2017 •
edited
Loading

node 8 does not accept null as encoding but. the default must be undefined when calling with start and end

nodejs/node#13936

@coveralls
Copy link

coveralls commented Sep 26, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 96.481% when pulling 72dbc80 on node-8-fix into c94ca93 on master.

@lipp lipp merged commit 20fe488 into master Sep 26, 2017
@lipp lipp deleted the node-8-fix branch September 26, 2017 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lipp @coveralls