-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite recursion on Windows (Sourcery refactored) #146
Conversation
raise ValueError("Invalid truth value: " + value) | ||
raise ValueError(f"Invalid truth value: {value}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function strtobool
refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation
)
return bool(value) if value == '' else bool(strtobool(value)) | ||
return bool(strtobool(value)) if value else bool(value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Config._cast_boolean
refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression
) - Replaces an empty collection equality with a boolean operation (
simplify-empty-collection-comparison
)
elif isinstance(default, Undefined): | ||
raise UndefinedValueError( | ||
f'{option} not found. Declare it as envvar or define a default value.' | ||
) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Config.get
refactored with the following changes:
- Merge else clause's nested if statement into elif (
merge-else-if-into-elif
) - Lift code into else after jump in control flow (
reintroduce-else
) - Replace call to format with f-string (
use-fstring-for-formatting
)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.45%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #137 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!